[nitpick] Stop docker container in CI#2
Merged
dranov merged 2 commits intoverse-lab:mainfrom Apr 29, 2025
Merged
Conversation
Contributor
|
Thanks for this, @ArquintL! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While browsing your CI workflow file, I got puzzled about the way how you set the exit code, which made me realize that
docker stop test-containeris not invoked in caselake buildexits unsuccessfully as running a script in a step aborts when encountering the first error.Thus, this PR sets
set +eto override this behavior. Since this has the potential of missing errors, I've split the affected step to apply this flag to the smallest number of bash commands.